OPM / opm-reference-manual

Other
1 stars 5 forks source link

Add SOURCE keyword to SCHEDULE section for 2024-04 #282

Closed gdfldm closed 3 weeks ago

gdfldm commented 4 weeks ago

fodt-add-keyword --keyword SOURCE --section 12.3 --title "Define Source Term" --status green --appendix

gdfldm commented 4 weeks ago

@hakonhagland. When I added the SOURCE keyword, the script put it Appendix A after SGUZ-, but it should be after SORWMIS. Please could you check the script? Note that SGUZ- is part of one of the subsets of keywords that are formatted differently.

I used: fodt-add-keyword --keyword SOURCE --section 12.3 --title "Define Source Term" --status green --appendix

hakonhagland commented 4 weeks ago

@gdfldm Yes I will check now :)

hakonhagland commented 4 weeks ago

There seems to be an issue with the link to SGU in appendix A also:

image

when I click on it I end up in SGOF in chapter 8 (instead of in the SGU section in chapter 8)

hakonhagland commented 4 weeks ago

When I added the SOURCE keyword, the script put it Appendix A after SGUZ-, but it should be after SORWMIS.

I believe #284 and #285 should solve this issue. I am not able to load main.fodt on my machine, so hope you check that this is the case @gdfldm

gdfldm commented 4 weeks ago

I believe #284 and #285 should solve this issue. I am not able to load main.fodt on my machine, so hope you check that this is the case @gdfldm

@hakonhagland. Many thanks. Will do :)

gdfldm commented 4 weeks ago

Just looking at A.fodt the SOURCE keyword is now in the correct position :)

But when I try to mark it as an OPM Flow keyword with: fodt-set-keyword-status --keyword SOURCE --color green --opm-flow I get:

INFO:root:Updating parameters for keyword SOURCE:  Color: KeywordStatus.GREEN, flow-specific keyword: True.
INFO:root:Found office:body.
INFO:root:Found 38 orange styles.
INFO:root:Using orange style Table47.H7.
INFO:root:Found 29 green styles.
INFO:root:Using green style Table45.H6.
INFO:root:Keyword SOURCE not found in ..\..\parts\appendices\A.fodt.

Perhaps it's the regex again? @hakonhagland. I have made the same change to regex in this script and it seems to work #286 :)

hakonhagland commented 4 weeks ago

Perhaps it's the regex again?

@gdfldm Indeed, thanks :) See #287.