search

OPM / opm-reference-manual

Other
1 stars 5 forks source link

Added links for keyword files in chapter 5.3 #411

Open hakonhagland opened 2 weeks ago

hakonhagland commented 2 weeks ago

Used the script in #410 to add links to all keyword files in Chapter 5.3. See #410 for more information.

gdfldm commented 2 weeks ago

I have created a PDF of the Manual based on this PR and it looks very nice. I think there are just a few special cases that should be addressed.

hakonhagland commented 2 weeks ago

@gdfldm Thanks for the detailed review! I have tried to address your comments in the latest commit.

gdfldm commented 2 weeks ago

@hakonhagland Thank you for all the updates. I have recreated the manual and found some places in Section 5 where we might want to mark up the documents by hand to avoid generating links but otherwise it looks good:

hakonhagland commented 2 weeks ago

found some places in Section 5 where we might want to mark up the documents by hand

@gdfldm Thanks! I checked the SATOPTS page now, and saw that KRNUMX and other similar keywords was not recognized. I think that is because they are not separate keywords in the manual. They are all described under the KRNUM keyword. Maybe the script should set up aliases for these?

gdfldm commented 2 weeks ago

Maybe the script should set up aliases for these?

Yes, I think so.

hakonhagland commented 2 weeks ago

@gdfldm See the last commit for updates to address the comments above.

hakonhagland commented 2 weeks ago

For keywords like KRNUMX- the "-" seems to be placed outside the tag

@gdfldm Good observation! I have fixed the script to handle this case. Check the latest commit for the result.

hakonhagland commented 1 week ago

Rebased