search

OPM / opm-simulators

OPM Flow and experimental simulators, including components such as well models etc.
http://www.opm-project.org
GNU General Public License v3.0
112 stars 122 forks source link

master branch broken? #1635

Closed GitPaean closed 5 years ago

GitPaean commented 5 years ago 
1809 /home/kaib/OPM-test/debug/opm-simulators/opm/autodiff/FlowMainEbos.hpp:534:73:   required from ‘void Opm::FlowMainEbos<TypeTag>::runSimulator() [with TypeTag = Ewoms::Properties::TTag::EclFlowProblem]’
1810 /home/kaib/OPM-test/debug/opm-simulators/opm/autodiff/FlowMainEbos.hpp:234:29:   required from ‘int Opm::FlowMainEbos<TypeTag>::execute(int, char**) [with TypeTag = Ewoms::Properties::TTag::EclFlowProblem]’
1811 /home/kaib/OPM-test/debug/opm-simulators/flow/flow_ebos_blackoil.cpp:59:39:   required from here
1812 /home/kaib/OPM-test/debug/ewoms/ewoms/linear/matrixblock.hh:212:46: error: ‘typedef class Dune::FieldMatrix<double, 3, 3> Ewoms::MatrixBlock<double, 3, 3>::BaseType’ is private
1813      typedef Dune::FieldMatrix<Scalar, n, m>  BaseType;
1814                                               ^
1815 /home/kaib/OPM-test/debug/ewoms/ewoms/linear/matrixblock.hh:255:8: error: within this context
1816  struct MatrixDimension<Ewoms::MatrixBlock<Scalar, n, m> >
GitPaean commented 5 years ago

the related commit is https://github.com/OPM/ewoms/pull/423/commits/bde227f4126b3bfeebb75a252409adb3f3bc488f ?

I do not understand the problem while just that commit change the corresponding line.

GitPaean commented 5 years ago

my dune version is 2.4.1 . Please let me know if it is something too old for OPM already.

dr-robertk commented 5 years ago

As I pointed out in the other PR it works for me. I'm using all master, including DUNE. So maybe the difference is buried somewhere there. BTW, DUNE 2.4 is ancient. I advise to upgrade to 2.6

GitPaean commented 5 years ago

okay. It is fine for OPM to update to newer dune version. I think OPM can stop supporting DUNE2.4.1 when OPM decides not to support Ubuntu 16.04.

dr-robertk commented 5 years ago

Then I suggest that you upgrade to ubuntu 18.04 ;-)

GitPaean commented 5 years ago

With dune 2.5.2 It is different error messages.

I can be wrong, since I seldom touch the version of DUNE. 

163 In file included from /home/kaib/OPM-master-test/debug/opm-simulators/opm/autodiff/NewtonIterationBlackoilInterleaved.cpp:39:0:
164 /home/kaib/OPM-master-test/debug/opm-simulators/opm/autodiff/ISTLSolver.hpp: In member function ‘void Opm::ISTLSolver<MatrixBlockType, VectorBlockType, pressureIndex>::solve(Opm::ISTLSolver<MatrixBlockType, VectorBlockType, pre    ssureIndex>::Matrix&, Opm::ISTLSolver<MatrixBlockType, VectorBlockType, pressureIndex>::Vector&, Opm::ISTLSolver<MatrixBlockType, VectorBlockType, pressureIndex>::Vector&) const’:
165 /home/kaib/OPM-master-test/debug/opm-simulators/opm/autodiff/ISTLSolver.hpp:287:55: error: ‘ParallelISTLInformation’ was not declared in this scope
166              if (parallelInformation_.type() == typeid(ParallelISTLInformation))
167                                                        ^
168 /home/kaib/OPM-master-test/debug/opm-simulators/opm/autodiff/ISTLSolver.hpp:290:23: error: ‘ParallelISTLInformation’ does not name a type
169                  const ParallelISTLInformation& info =
170                        ^
171 /home/kaib/OPM-master-test/debug/opm-simulators/opm/autodiff/ISTLSolver.hpp:292:31: error: ‘info’ was not declared in this scope
172                  Comm istlComm(info.communicator());
173                                ^
dr-robertk commented 5 years ago

Fixed by https://github.com/OPM/ewoms/pull/429

GitPaean commented 5 years ago

The above error message with DUNE 2.5.2 is not related to OPM/ewoms#429 . Can be a problem of my own build of DUNE unless some people see the same.

Will test it again with rebuilt DUNE again later when finding time.

dr-robertk commented 5 years ago

The corresponding patch was merged, closing.

andlaus commented 5 years ago

the latest issue above is caused by some now-mandatory header files not being included by ISTLSolverEbos.hpp. They have become mandatory because of the recent legacy-related cleanup. The problem is that what's mandatory is highly dependent on the concrete configuration...

GitPaean commented 5 years ago

the latest issue above is caused by some now-mandatory header files not being included by ISTLSolverEbos.hpp. They have become mandatory because of the recent legacy-related cleanup. The problem is that what's mandatory is highly dependent on the concrete configuration...

Thanks for the information. When I find time (probably next month), I will do some experiments with it.

blattms commented 5 years ago

Then I suggest that you upgrade to ubuntu 18.04 ;-)

We should not suggest broken (in the sense of MPI not working) ubuntu versions.

dr-robertk commented 5 years ago

Good point. Then we should wait for 20.04 ;-). I guess the MPI version in ubuntu 18.04 will be fixed a some point. I will also check if we can provide newer DUNE packages for the existing ubuntu versions.