search

OPM / opm-simulators

Simulator programs and utilities for automatic differentiation.
http://www.opm-project.org
GNU General Public License v3.0
112 stars 122 forks source link

Build error with dune-fem branch release/2.9 #4934

Open blattms opened 11 months ago

blattms commented 11 months ago 
[  0%] Building CXX object CMakeFiles/opmsimulators.dir/ebos/collecttoiorank.cc.o
In file included from /home/mblatt/src/dune/opm-release-2.9/opm-simulators/ebos/collecttoiorank.cc:32:
/home/mblatt/src/dune/opm-release-2.9/dune-fem/dune/fem/gridpart/common/gridpart2gridview.hh:4:2: warning: #warning "This header should not be needed anymore. Remove it from the include list!" [-Wcpp]
    4 | #warning "This header should not be needed anymore. Remove it from the include list!"
      |  ^~~~~~~
In file included from /home/mblatt/src/dune/opm-release-2.9/opm-simulators/ebos/femcpgridcompat.hh:37,
                 from /home/mblatt/src/dune/opm-release-2.9/opm-simulators/ebos/collecttoiorank.cc:33:
/home/mblatt/src/dune/opm-release-2.9/dune-fem/dune/fem/misc/compatibility.hh:4:2: error: #error COMPATIBILITY HEADER SHOULD NOT BE USED ANYMORE: make_entity can be removed
    4 | #error COMPATIBILITY HEADER SHOULD NOT BE USED ANYMORE: make_entity can be removed
      |  ^~~~~
blattms commented 11 months ago

Maybe somebody using dune-fem more often could take a look? @atgeirr @ElyesAhmed @hnil

Might be as simple as stopping to use GridPart2GridView, see comment of Andreas Dedner at https://gitlab.dune-project.org/dune-fem/dune-fem/-/issues/170 Of course our backwards compatibility with 2.7 (is that correct?) might bite us here. But maybe for people using dune-fem supporting just 2.8 and 2.9 if dune-fem is there is good enough.

blattms commented 11 months ago

Like I said comments and work from people using dune-fem are highly appreciated.