Remove actionx_callback

OPM / opm-tests

Data sets intended for integration and regression testing reservoir simulations

29 stars 59 forks source link

Remove actionx_callback #1138

Closed lisajulia closed 7 months ago

lisajulia commented 7 months ago

In https://github.com/OPM/opm-common/pull/3948, I've removed the actionx_callback, this PR removes it in opm-tests as well.

blattms commented 7 months ago

Is there any dependency between the two PRs (like one does not compile without the other?

lisajulia commented 7 months ago

Thanks for notifying! I'm closing this now since we have decided in the last meeting to actually keep the actionx_callback

blattms commented 7 months ago

Seems like the script is used in udq_actionx/PYACTION_WCONPROD which we run a regression one. Maybe we should even have two versions (one with and one without callback) and ideally even compare their results.