OPM / opm-tests

Data sets intended for integration and regression testing reservoir simulations
28 stars 57 forks source link

Add a test to illustrate ACTNUM with CARFIN #1198

Closed aritorto closed 1 week ago

aritorto commented 2 months ago

This PR adds a test with the purpose of illustrating improvements on refinement in Corner Point grids. Precisely, the old-requirements of

Attached 2 screenshots of the grid with all the cells active, and 2 with 3 inactive cells (one of them inside the LGR, the other 2 cells outside the LGR).

The improvements on the refinement for Corner Point grids related to inactive/active cells are in OPM/opm-grid#734. Additionally, global refinement is in OPM/opm-grid#732. Finally, refine a mixed grid (with coarse and refined cells), in OPM/opm-grid#731.

aritorto commented 2 months ago

Screenshot from 2024-07-08 08-27-27 Screenshot from 2024-07-08 08-27-09 Screenshot from 2024-07-08 08-25-41 Screenshot from 2024-07-08 08-25-25

aritorto commented 2 months ago

jenkins build this please

blattms commented 1 month ago

I think we should add a comment about ACTUM (what cells are inactive) to the top comments in that file. E.g. "this test based on test ..., but we deactivated ..."

blattms commented 1 month ago

On the other hand, I am not sure whether it makes sense to have this test here. It has an injector well in the first cell and a producer in the last cell, but due to inactive cells between them there will be no flow. Hence it can be used to test the grid code but not really a full simulation.

It might make more sense to use the model in opm-grid only or to add another layer of cell to allow for flow.

aritorto commented 1 month ago

Thanks for your feedback @blattms! I knew that physically the test was not relevant. I'll draft this PR and work on a more meaningful test.

aritorto commented 1 week ago

Close it for being meaningless/non-relevant.