search

OPORA / publicwhip

Helping you find out if your MP represents you by analysing their votes in Ukraine's parliament for you.
https://rada4you.org/
Other
16 stars 1 forks source link

Commit code @beastie #164

Closed beastie87 closed 8 years ago

beastie87 commented 8 years ago

Hi! Where I can commit my code? Thank you!

henare commented 8 years ago

Hi @beastie87, great to see your first commit!

With simple ones like that you can commit straight to develop, however don't forget to make sure your tests pass as we run Travis CI.

For anything more complex you can also open a pull request and ask us to review and merge it.

henare commented 8 years ago

I should also add a bit about translations. Obviously we're trying to change as little as possible how the application works so that we can merge this upstream at some time soon in the future.

For any translations to views we're just copying the view to a localised template, committing that, then making any changes. This allows us to really easily diff these views against the originals to see the changes.

For any changes to helpers we're trying to use gettext where possible (example).

Using these techniques allows the application's tests to still pass with no changes because they're still testing against the English version.

If there's no easy way to translate helpers using gettext we're falling back to these hacky exceptions of checking the locale in an if block, (example). This should be used as a last resort only because we'll have to change this when we merge upstream.

henare commented 8 years ago

@beastie87 please open a pull request with your changes: https://github.com/OPORA/publicwhip/compare/develop...OPORA:beastie

While there's lots of good changes, there are some hacks in there I'd be strongly against merging.