search

OPORA / publicwhip

Helping you find out if your MP represents you by analysing their votes in Ukraine's parliament for you.
https://rada4you.org/
Other
16 stars 1 forks source link

Division title with member position translation #169

Closed equivalentideas closed 8 years ago

equivalentideas commented 8 years ago

This is the translation for the title of the page showing home an individual MP voted on a vote. This closes https://github.com/OPORA/publicwhip/issues/96

Here’s some examples of the Ukrainian text this produces: screen shot 2015-12-09 at 5 04 49 pm screen shot 2015-12-09 at 5 04 40 pm screen shot 2015-12-09 at 5 04 35 pm

Could you please check if these are correct @orybiy @lisoffsky ^^^ ?

Here are some of the pages where this will appear on rada4you:

See an example of one of these pages in English here https://theyvoteforyou.org.au/people/representatives/wentworth/malcolm_turnbull/divisions/2014-10-22/7

equivalentideas commented 8 years ago

@henare @beastie87 could one of you please review this code and make any suggestions for improvement or merge if/when the tests pass?

henare commented 8 years ago

Nice work finally making it through this complexity.

The "in the majority/minority" part of the sentence only takes into consideration yes/no votes. I guess you could argue that's the only actual vote but it's a bit of a tortured argument.

I think we'll have to tweak something there but let's merge this as a first pass.

henare commented 8 years ago

Deploying :rocket: with:

bundle exec mina ukraine-production deploy
henare commented 8 years ago

Deployed :shipit:

equivalentideas commented 8 years ago

The "in the majority/minority" part of the sentence only takes into consideration yes/no votes. I guess you could argue that's the only actual vote but it's a bit of a tortured argument.

I think we'll have to tweak something there but let's merge this as a first pass.

Sounds good to me :+1: Thanks :whale: