search

OPSkins / trade-opskins-api

API docs for trade.opskins.com
41 stars 19 forks source link

Add IItem/GetItemDefinitions #112

Closed Voyager-Two closed 5 years ago

jor112358 commented 5 years ago

please add 'sku' field in the results, thx!

jor112358 commented 5 years ago

it should be better to add 'sku_filter' , to fully replace with the deprecated 'IItem/GetItems' api. or I have to download all the item definition to build a map of sku -> [item_definition].

jor112358 commented 5 years ago

I fetched all the infomations from ITrade/GetApps and IItem/GetItemDefinitions, and found that different apps are sharing the same skus, for example, (def_id: 100, 900000002, 900000003, 900000004, 900000005, 900000006), CryptoKitties and VGO are sharing the same sku 100, contains def_id of 100, 900000002, 900000003, 900000004, 900000005, 900000006.

And the document said IItem/GetItems "is deprecated in favor of IItem/GetItemDefinitions", but I cannot simply replace GetItems with GetItemDefinitions, because when firstly I got case schemas from ICase/GetCaseSchema, I have no way to get item definitions with skus automaticaly in my codes.