search

OPSkins / trade-opskins-api

API docs for trade.opskins.com
41 stars 19 forks source link

Two trades cannot be sent in the same authentication window #42

Closed almatrass closed 6 years ago

almatrass commented 6 years ago

When sending a trade over the ITrade/SendOfferToSteamId endpoint, the current valid 2FA code must be provided. Once provided, if another trade is sent when that code is still valid, the trade cannot be sent until a new one is generated. This is no problem for now in testing, but if the site scaled to hundreds of active users, users could be waiting for a long time for their trades to find a gap in the code generation and another user initiating trade. What's the proposed solution to this? Either OPSkins should be allowing the same auth code to be used, or a new endpoint should be created to allow the sending of multiple trades at once

almatrass commented 6 years ago

Didn't check existing issues https://github.com/OPSkins/trade-opskins-api/issues/37