Differentiate between a missing checksum and a modified log

OPSnet / Logchecker

Logchecker for parsing and scoring logs coming from CD ripping programs

The Unlicense

57 stars 11 forks source link

Differentiate between a missing checksum and a modified log #3

Closed itismadness closed 4 years ago

itismadness commented 5 years ago

Right now, we mark both a missing checksum as well as a modified log as the same ($this->Checksum = false). This should be more fine grained such that there's say $this->ChecksumPresent and $this->ChecksumValid such that the first could be true and the second false to show a modified log while if the first is false, then there's no checksum.

itismadness commented 4 years ago

Done in a084b8a49489105cd1c6d2ff2de67781cec1913d. Checksums can now have three states:

\OrpheusNET\Logchecker\Check\Checksum::CHECKSUM_OK === 'checksum_ok'
\OrpheusNET\Logchecker\Check\Checksum::CHECKSUM_MISSING === 'checksum_missing'
\OrpheusNET\Logchecker\Check\Checksum::CHECKSUM_INVALID === 'checksum_invalid'