OPTML-Group / Unlearn-Saliency

[ICLR24 (Spotlight)] "SalUn: Empowering Machine Unlearning via Gradient-based Weight Saliency in Both Image Classification and Generation" by Chongyu Fan*, Jiancheng Liu*, Yihua Zhang, Eric Wong, Dennis Wei, Sijia Liu
https://www.optml-group.com/posts/salun_iclr24
MIT License
90 stars 12 forks source link

Train Conditional DDPM on all 10 classes of CIFAR10? #4

Closed tqch closed 6 months ago

tqch commented 6 months ago

Hi there,

Thank you for sharing your great work! I have a quick question regarding the training of CIFAR10 conditional diffusion. Based on the code: https://github.com/OPTML-Group/Unlearn-Saliency/blob/48824303a19d2a89508d22bc3a5ca5a801f81629/DDPM/train.py#L27-L32 and runner.train() https://github.com/OPTML-Group/Unlearn-Saliency/blob/48824303a19d2a89508d22bc3a5ca5a801f81629/DDPM/runners/diffusion.py#L193-L200 https://github.com/OPTML-Group/Unlearn-Saliency/blob/48824303a19d2a89508d22bc3a5ca5a801f81629/DDPM/runners/diffusion.py#L217-L219 The label 0 is forgotten even for standard training. Consequently,

CUDA_VISIBLE_DEVICES="0,1" python train.py --config cifar10_train.yml --mode train

does not yield a complete conditional model on all 10 classes. Is my understanding correct?

If so, could the authors verify that their results of CIFAR-10 class-wise unlearning in the paper are unaffected and based on the correct implementation.

a-F1 commented 6 months ago

Thank you for your interest and appreciation of our work. We want to assure you that the implementation of our local code is accurate. As outlined in the paper, during the training process, we utilize 10 classes to establish a conditional model as original model. We apologize for any inconvenience caused by the delayed code update and have promptly synchronized it to the latest version. The images presented here are the result of our well-trained model. In this visualization, each row corresponds to a specific class. Notably, the conditional model demonstrates its capability to generate images aligned with the specified label when a particular label is input.

original_sample

We trust that these explanations address any concerns you may have and prove valuable in your ongoing experiments. Should you have further inquiries or require additional assistance, please don't hesitate to contact us.

tqch commented 6 months ago

Thank you for your prompt and detailed response!