OPUSVIER-3657 Refactoring of logging setup

OPUS4 / opus4-common

Core package for OPUS 4.

Other

0 stars 5 forks source link

OPUSVIER-3657 Refactoring of logging setup #18

Closed kaustabhbarman closed 4 years ago

kaustabhbarman commented 4 years ago

Continued from #17

j3nsch commented 4 years ago

Please pick up the latest changes on master (workflow configuration) in order to enable actions for pull requests. It should work now.

j3nsch commented 4 years ago

Please add a test for the situation that "logging.log" does not exist in the configuration ($config->logging->log). The function getLogConfig should not throw an exception in that case and should return a configuration object with the default values.

kaustabhbarman commented 4 years ago

Should the test compare the same doiLogConfig with the returned config? I am assuming the difference will be that the new test won't merge logging.log into the config.