Preprocessor updates to surface reflectance

ORAC-CC / orac

Optimal Retrieval of Aerosol and Cloud

GNU General Public License v3.0

30 stars 20 forks source link

Preprocessor updates to surface reflectance #29

Closed simonrp84 closed 4 years ago

simonrp84 commented 4 years ago

This PR does two things: 1) Prevent calculation of surface reflectance + BRDF data for night-time pixels. This data is unnecessary (as it's night, there's no solar reflectance) and just takes up processing time. 2) Remove a hack in the cox_munk code that was used to flip the relative azimuth angles. Now that we're fixing the RAA in the satellite readers we no longer need this flip.

adamcpovey commented 4 years ago

Shouldn't you also update the comments to represent the new reality of the code in Cox-Munk?

I haven't finished going through the maths yet as I've been taking some time off around meetings. Am like 90% sure this is the right choice.

simonrp84 commented 4 years ago

I forgot that this was the one bit of code with good comments in it. ;-) Removed now, thanks.