search

ORAC-CC / orac

Optimal Retrieval of Aerosol and Cloud
GNU General Public License v3.0
30 stars 20 forks source link

Update ecmwf flags and enable support for ERA5 data on JASMIN #56

Closed simonrp84 closed 3 years ago

simonrp84 commented 3 years ago

This PR enables support for the ERA5 data on JASMIN, which comes in lots of separate files rather than one large netCDF4 file as currently supported by ORAC. This PR also rearranges the ecmwf_flag options as described below:

0: NOAA GFS (current 6)
1: ECMWF OPER + ERA5 as single netCDF (current 4+5)
2: ECMWF ERA5 in mad JASMIN format (new)
3: DWD format (current 3)
4: ERA-Interim in JASMIN format (current 2)

I have also renamed ecmwf* variables to nwp* as this seems more consistent and sensible.

adamcpovey commented 3 years ago

I have now compiled and briefly tested this on JASMIN. It seems to work fine, with no regressions in the ERA-Interim interface and vaguely sensible ones with ERA5.

I have made the necessary changes to PyORAC, though it would be good if @simonrp84 could add the filename format for NOAA and @danielphilipp could add the filename format for the files DWD uses. (There are currently NotImplementedError for these values of ecmwf_flags.)

All I'd say needs to be done before we merge is someone does a quick pass to take out references to the old flag values.

simonrp84 commented 3 years ago

This should be fixed now. I will make an interim ORAC release to mark this point (enabling others to find the 'old' ecmwf later) and then merge.