ORAC-CC / orac

Optimal Retrieval of Aerosol and Cloud
GNU General Public License v3.0
30 stars 19 forks source link

Add Python interfaces for LUTs and a forward model implementation #85

Open adamcpovey opened 1 year ago

adamcpovey commented 1 year ago

This adds,

I'm not done with this yet, but enough of it works I felt I should throw the code out there for people to look at. Can anyone actually work out how to run the examples? Would they be better as PDFs or hosted somewhere else where I can embed the files alongside? Do any of these things look useful?

adamcpovey commented 6 months ago

@garethethomas considering the two people I asked for opinions on this don't work for us any more, who should I throw it to? Elisa or Dora seem the most likely to actually want a Python forward model.

simonrp84 commented 6 months ago

I never looked at this as I didn't have a need for a forward model outside ORAC.

That said, I've just taken a quick look at the code and it looks OK....aside from various linting issues. I strongly suggest running this through pylint or similar to highlight issues. There's a few places where uninitialised values are used, or class variables aren't referred to with self. etc. VSCode or PyCharm will be able ot fix almost all of these automagically.