search

ORAC-CC / orac

Optimal Retrieval of Aerosol and Cloud
GNU General Public License v3.0
28 stars 19 forks source link

Add external SEVIRI ML capability to ORAC, with some small bugs fixed #97

Open dhegedus99 opened 3 months ago

dhegedus99 commented 3 months ago

This is building on PR74, updated to the current version of ORAC, and some bugs regarding the indexing of channels fixed. It enables the use of the external SEVIRI ML module within ORAC.

simonrp84 commented 3 months ago

I see that the mapping of channels is hardcoded in this and that, unless I'm mistaken, processing will fail if the Ozone channel is included as in this case the channel ordering will be incorrect for the subsequent IR channels. Even though the Ozone channel isn't much use, this strikes me as a bit dangerous so it should be tested for in the code.

simonrp84 commented 3 months ago

Just a note, it'd be better to do whitespace tidying in a separate PR after this one has been merged as it's now very difficult to see what updates @dhegedus99 has made and what are whitespace changes due to the number of changed files. One PR for one topic is best, IMO.

adamcpovey commented 3 months ago

It started as just a whitespace tidy of what she changed but, once I had the macros, I ran them on the whole repo. Also, whitespace changes can be automatically filtered out of any git diff. On Github, click the Gear at the top of the page, then select the "hide whitespace" tickbox.

And I'd disagree slightly that a PR is for a change. A commit is for a change. A PR is for a thematically linked set of changes. These probably should have been in a separate commit but (a) pushing to main would mess up the other PRs, (b) I was already juggling three forks of this repo and had buggered it once already so I stopped being clever.