search

ORB-HD / deface

Video anonymization by face detection
MIT License
680 stars 94 forks source link

ffmpeg-config issue with fps #24

Closed Karl48071 closed 2 years ago

Karl48071 commented 2 years ago

Looking at the ffmepg-imageio docs, there does appear to be a parameter called "fps" that changes the output frames per second rate of the anonymized video. However, when setting ffmpeg-config '{"fps": 15} I get an error of: got multiple values for argument 'fps'

How do you properly set that parameter so that the output video is 15 frames per second?

mdraw commented 2 years ago

The fps is already passed explicity here based on the source video fps value: https://github.com/ORB-HD/deface/blob/5d5c33acdb7d5f44b5bc3e785c0db37a6e40d89d/deface/deface.py#L140. I had implemented it like this because I did not think there was a use case for simultaneously anonymizing a video and changing its frame rate.

Edit: My workaround code didn't work. Pushing an actual fix now.

mdraw commented 2 years ago

Please update from the latest git version and feel free to reopen if you encounter any problems.

Karl48071 commented 2 years ago

Thank you!!