search

ORNL-AMO / AMO-Tools-Desktop

AMO-Tools-Desktop is an energy efficiency calculation application for use with industrial equipment such as pumps, furnaces, fans, and motors, as well as for industrial systems such as steam. Currently in beta.
Other
37 stars 21 forks source link

Allow users to set $ or $k #3554

Open koay9f opened 4 years ago

koay9f commented 4 years ago

Make costs a unit (will help for future internationalization as well) Can change between $ and $k Global setting, Assessment Type Setting & Individual assessment setting

koay9f commented 2 years ago

So this was a lot of work and some things were going to get missed. You got most of it, there are a few places where it seems like the conversion just isn't happening (pumps assessment, all of motors), some places where we need to add the "k" label, and figure out the roll up reports.

I know you only have one day left, so if you get any of it done, leave notes in here, but someone else can pick it up.

Pumps: - need to do unit conversion approval - that's odd Field Data - missing Explore Ops - missing Modify All - missing report= good image.png

fans: Field data - good Explore Ops - good Modify All - good report- good

steam: Explore Ops - conversions are right, need more labels Modify All - same Diagram - need to add labels to show in thousands (maybe $26,277k) report - good image.png image.png

Process heating: Explore Ops- na Modify All - na report - good

Waste water: Aerator Performance - good Explore - good Modify all - good report - good

Treasure Hunt: Treasure Chest - It looks like this may have worked, but I think something got screwed up in the total cost savings Example - $ image.png Example - $k image.png

Motor inventory - Catalog - no change Summary - no change Analysis - no change

Roll up reports - Need something to do conversions when in a rollup. Right now it is just assuming that the cost values are in $, so $k is messing things up. image.png image.png Maybe add $ & $k to the rollup units? image.png

shivasaurus commented 2 years ago

Didn't complete any additional work on this.

nbintertech commented 2 years ago

Can close #2803 if all good.

koay9f commented 2 years ago

Still not doing a conversion in ... Pumps: System Setup >Field data > Annual Cost Pumps: Report > Result Data > Annual & Savings - I think is doing a double conversion (if you look at the example annual cost should be 152 $k, but is instead showing as "00") Treasure Chest - mostly good. "Other Cost Savings" % is still wonky (same as above pic) and report is a bit wonky $ image.png $k image.png Also in Opportunity Summary, Payback Details, Report graphs (but since hte probably will probably be fixed before those are generated, I imagine that it will just filter though...)

Folder cards - showing results as "Annual Energy Costs: $152" and "Max Costs Savings $19" (instead of $152k and $19k). Adding wrong in the summary cards also. Roll up - the k is in the units, but it still assumes that everything in the folder is in the same currency units. need to do something similar to if we have mixed metric & imperial units

Other weird... Pumps: Assessment>Explore Opps>Annual Cost displays with a 0 in the "tens" slot (so 6 shows as 06)

nbintertech commented 2 years ago

Turning off this currency setting until we can prioritize time to make the required changes to the TH section

nbintertech commented 2 years ago

@JL102 Pick this up if you run out of all else. The remote for this is up to date and we should discuss before you begin