ORNL-AMO / AMO-Tools-Desktop

AMO-Tools-Desktop is an energy efficiency calculation application for use with industrial equipment such as pumps, furnaces, fans, and motors, as well as for industrial systems such as steam. Currently in beta.
Other
37 stars 21 forks source link

Angular 13 update #4533

Closed nbintertech closed 2 years ago

nbintertech commented 3 years ago

update to Angular 13

rmroot commented 3 years ago

While you are at it can you make sure to check out all vulnerabilities that show up on npm install please

nbintertech commented 3 years ago

Branch is updated to ng 12 and compiling/running successfully. There are 2 loose ends:

  1. Initial build time is ridiculously slow (15-20 mins)
  2. There is a deprecated :lang selector somewhere in our 3rd party styles
    • Also need some researching to find where this is. Possibly upgrade to bootstrap 5 or if there is a minor 4 release that removes :lang ng12.png.
nbintertech commented 2 years ago

Try this again once we get MEASUR / WASM integrated

nbintertech commented 2 years ago

Updated to Angular 13 and can't build due to webpack errors. Branch at issue-4533-b

Problem:

Targetting plotly 1.58 or Plotly 2.6.2 -2.9 (problem occurs on 'stream' in this v), I tried:

At this point, looking at VERIFI, maybe the MEASUR tsconfig needs a revamp. If all else fails there is a package to modify a custom webpack config with a few lines. Not ideal

Fall back solution --> the upgrade to Angular 12 built fine.