CA Performance - Ref/object copies

ORNL-AMO / AMO-Tools-Desktop

AMO-Tools-Desktop is an energy efficiency calculation application for use with industrial equipment such as pumps, furnaces, fans, and motors, as well as for industrial systems such as steam. Currently in beta.

Other

39 stars 21 forks source link

CA Performance - Ref/object copies #6117

Open nbintertech opened 1 year ago

nbintertech commented 1 year ago

Check in before starting.

Find opportunities to remove JSON.parse/copy where it doesn't break functionality or copy is not needed. Start with compressed-air-results.service or largest place of bottle neck. Create additional issues if this is successful

If we can't come up with a 100% way or non-extremely tedious way to test results of all instances where this is used... we should just replace with _.cloneDeep() since it's marginally faster and serializes object types better

nbintertech commented 1 year ago

Added lodash _cloneDeep in place of JSON copies Look at redundant usage of hasValidProfileSummaryData(). Can probably just run this on updateCompressedAir() and set as property on compressedAirAssessment.

nbintertech commented 5 months ago

Putting to backlog

AFAIK the performance of CA is stable. Modifying all the places where this is accessed is more risky than worth it until something changes.