ORNL-AMO / AMO-Tools-Desktop

AMO-Tools-Desktop is an energy efficiency calculation application for use with industrial equipment such as pumps, furnaces, fans, and motors, as well as for industrial systems such as steam. Currently in beta.
Other
39 stars 22 forks source link

PF correction review #6921

Closed koay9f closed 4 weeks ago

koay9f commented 3 months ago

Notes from Chris: Ok, first comment, can it be made so that you can change the name of the month? Something other than "Month 1", "Month 2", etc.? "Annual Power Factor Penalty" in results should have a $

Tweak to accommodate new combination of data found at an INPLT by Chris In the "PF Adjusted or Actual Demand" drop down, I'd add an option for something like "Both" You'd have to add a third column here (koa - this sounds a little cramped to me, how does this look in mobile already? I guess they don't need to be wide input boxes...)

image.png

The user would essentially enter this column as well, the rest of the results would be calculated normally (koa - in other words, do not calculate this column, but calculate the rest based on this data)

image.png

(koa - he then doubts himself) Does that make sense?

koay9f commented 3 months ago

Re: editable fields - Other option - new dropdown that is "First month" and has a list of the twelve months.
Month 1 = "First Month" Month 2 = next... Add month --> whatever month is next

koay9f commented 3 months ago

from chris: [2:56 PM] Price, Chris Other note for the PF Correction calculator, need to add a warning for when you drop below 3 months of data

I would say you just shouldn't be able to drop below 3 months of data...

koay9f commented 3 months ago

Chris requests that the "Delete Month" button be moved next to teh "Add Month Button" (since it is only deleting the last month anyway) and can these be on same "row" as Generate Example or Reset Data When you have "Both" can the order of the input table be: "Actual", "PF Adjusted Demand", "Power Factor" (so Power Factor is always on right)

Chris says otherwise it looks great!

BUG: FYI - things get buggy if: how demand = "Real Power" PF Adjusted/Actual Demand = "Both" THEN how demand = "Apparent Power"

koay9f commented 2 months ago

Still there: BUG: FYI - things get buggy if: how demand = "Real Power" PF Adjusted/Actual Demand = "Both" THEN how demand = "Apparent Power"

image.png