search

ORNL-AMO / AMO-Tools-Desktop

AMO-Tools-Desktop is an energy efficiency calculation application for use with industrial equipment such as pumps, furnaces, fans, and motors, as well as for industrial systems such as steam. Currently in beta.
Other
39 stars 22 forks source link

CA Sankey Bug #7073

Open rmroot opened 2 weeks ago

rmroot commented 2 weeks ago

From Alex:

The compressed air sankey tab was not showing any content for the inplant data she had. See me for the data file.

I narrowed it down to the power-sankey.service.ts getAirPropertiesLookupData function. The lowRangeProperty is coming back as undefined for one of the values. I've pushed up a branch with my temporary fix (issue-7073).

I also was unable to go to the "Airflow Sankey" tab. Didn't get any errors and didn't investigate.

nbintertech commented 1 week ago

Airflow sankey is disabled (it does not exist)

It seems to me that low pressure bound needs to be greater than 0 - in the user data it is negative. Will check with Alex about whether low pressure bound being negative is a valid case, and what should be done either way

nbintertech commented 1 day ago

PSIA TO PSIG AND PSIG TO PSIA conversions in the sankey algo were incorrect (used shared convertUnitService, instead of +/- atmosP), creating negative pressure values and killing the sankey.