search

ORNL-AMO / AMO-Tools-Desktop

AMO-Tools-Desktop is an energy efficiency calculation application for use with industrial equipment such as pumps, furnaces, fans, and motors, as well as for industrial systems such as steam. Currently in beta.
Other
39 stars 22 forks source link

Co2 Electricity Emissions are not carrying over values to mod anymore #7116

Closed nbintertech closed 1 week ago

nbintertech commented 2 weeks ago
  1. User entered emissions are not copied over to the modification from baseline
  2. When creating a new assessment, if electricity emissions input is 0, that should be reflected in the new modification.

Found while looking at #6993

nbintertech commented 2 weeks ago

Tested for electricity, fuel, mixed fuels in all assessments (not incl TH and CA).

Measur assessments have 4 ways a mod can be added: 'explore oppoprtunities' button, explore opps -> 'add new scenario' button', 'add modified condition' button, 'view / add scenario' modification list. Each assessment has a separate set of logic for each button, while the logic appears to be the same

nbintertech commented 1 week ago

Via slack "pumps, "Explore Opportunities" button brings up a modal, but the "create" button doesn't work"

Please try above again, can't reproduce. Tested fsat and psat. the issue may have started from an already corrupted state due to issues from the emissions unit settings not upgrading

koay9f commented 1 week ago

Still an issue. I cleared all my data. created a pump assessment, went to mod (explore or expert), clicked explore opps (or create), then create and nothing happened.
pumps - error ph - no error fan - error stm - no error ww - error ca - no error

if I go to CO2 field and "wiggle it" it will let me move on. is this something that normal users will encounter or a problem from being in dev?

can show on monday

image.png
nbintertech commented 1 week ago

Fixed. Here's what happened: the changes I made accessed a property that's only available if the operations tab was visited. I'm assuming you didn't visit the tab in the new assessments because the tab is already valid. I didn't originally encounter the issue above because I was always visiting (to test 2. above).