search

ORNL-AMO / AMO-Tools-Suite

AMO-Tools-Suite is an energy efficiency calculation library in C++ with optional Nan Node add-on bindings for the Department of Energy Advanced Manufacturing Office (DOE AMO) Desktop, also known as MEASUR.
Other
22 stars 12 forks source link

Basin heater calculation tweak #596

Closed koay9f closed 3 years ago

koay9f commented 3 years ago

Issue overview

Need to add panLossRatio to bindings

quick change to lines 156 - Original


            const double ratedCapacity, const double ratedTempSetPoint, const double ratedTempDryBulb, const double ratedWindSpeed,
            const double operatingTempDryBulb, const double operatingWindSpeed, const double operatingHours,
            const double baselineTempSetPoint, const double modTempSetPoint){
        const double calc1 = ratedCapacity * 0.038676 /        /*0.038676 = 12000 * 0.011 / 3413*/
                (ratedTempSetPoint - ratedTempDryBulb) /
                pow((ratedTempSetPoint + ratedTempDryBulb) / 2,-0.181) /
                pow((ratedTempSetPoint - ratedTempDryBulb),0.266) /
                pow((1.277 * ratedWindSpeed + 1),0.5) *
                pow((1.277 * operatingWindSpeed + 1),0.5);``

replace with
```    static PowerEnergyConsumptionOutput BasinHeaterEnergyConsumption(
            const double ratedCapacity, const double ratedTempSetPoint, const double ratedTempDryBulb, const double ratedWindSpeed,
            const double operatingTempDryBulb, const double operatingWindSpeed, const double operatingHours,
            const double baselineTempSetPoint, const double modTempSetPoint, const double panLossRatio){
        const double calc1 = ratedCapacity * 4.3936731107 * panLossRatio /        /*4.3936731107 = 15000 btu/hr/ton  / 3413 kW/btu */
                (ratedTempSetPoint - ratedTempDryBulb) /
                pow((ratedTempSetPoint + ratedTempDryBulb) / 2,-0.181) /
                pow((ratedTempSetPoint - ratedTempDryBulb),0.266) /
                pow((1.277 * ratedWindSpeed + 1),0.5) *
                pow((1.277 * operatingWindSpeed + 1),0.5); ```
omerbaa commented 3 years ago

update applied to calc, test(s) updated

koay9f commented 3 years ago

what branch is this in?