ORNL-AMO / AMO-Tools-Suite

AMO-Tools-Suite is an energy efficiency calculation library in C++ with optional Nan Node add-on bindings for the Department of Energy Advanced Manufacturing Office (DOE AMO) Desktop, also known as MEASUR.
Other
20 stars 12 forks source link

Compressed Air: Air Leak Survey Orifice Method #644

Closed AlexBotts closed 2 years ago

AlexBotts commented 2 years ago

There is a bug somewhere in the calculation. The original excel sheet is giving the proper answer but doesn't match MEASUR. Alex is combing through to find the issue.

AlexBotts commented 2 years ago

StandarDensity and sonicDensity are being calculated incorrectly. I also don't see caDensity being calculated at all or a conversion for user input from F to R... for metric this conversion for temp will be different.

airTempRankine = airTemp + 459.67 'converting F to R you may want to do this on the desktop side caPressurePSIA = supplyPressure + atmpressure caDensity = (caPressurePSIA 144 / 53.34 airTempRankine) standardDensity = atmpressure 144 / (53.34 airTempRankine)) sonicDensity = (caDensity * (2 / (1.4 + 1)) ^ (1 / (1.4 - 1)))

AlexBotts commented 2 years ago

Assuming calculations above work out, the label on the UI for SupplyPressure will need updated to "psig"

rmroot commented 2 years ago

@AlexBotts looking at the excel you sent me I think:

caDensity = caPressurePSIA 144 / (53.34 airTempTankine)

rmroot commented 2 years ago

Okay so the rest of the calculations for compressed air are done with an air temp of Fahrenheit not Rankine. So I am going to do the conversion in the suite in this case.. However, wondering if the airTemp for the leakVelocity calculation should be in Rankine or Fahrenheit

image.png

AlexBotts commented 2 years ago

good catch, yes, that value for leak velocity should be in rankine

rmroot commented 2 years ago

Will need local suite develop to get changes

koay9f commented 2 years ago

the caDensity should be outside the power function for the calcuation of sonicDensity

image.png