System Capacity: Resolve rounding issue

ORNL-AMO / AMO-Tools-Suite

AMO-Tools-Suite is an energy efficiency calculation library in C++ with optional Nan Node add-on bindings for the Department of Energy Advanced Manufacturing Office (DOE AMO) Desktop, also known as MEASUR.

Other

22 stars 12 forks source link

System Capacity: Resolve rounding issue #715

Closed nbintertech closed 3 months ago

nbintertech commented 6 months ago

Issue overview

see #6802

Add more decimal precision.

From original issue: From @AlexBotts

Entered field value 8500 becomes 8501. What calculations are happening here?

8500 gal is given to the suite as input. When it's passed back as output the value appears to be in ft3 (1136.36363636 ft3). MEASUR then converts this back to gal using our global conversion resulting in 8500.58 rounded to 8501 gal.

CompressedAir.cpp line 111

koay9f commented 3 months ago

let's see what happens if you use whatever the conversion is between ft3 and gal in the unit converter in the desktop instead of 7.48

rmroot commented 3 months ago

updated to: 7.480515625

Screenshot 2024-08-23 at 12.52.34 PM.png