search

ORNL-CEES / Cap

A library for modeling energy storage devices.
http://cap.readthedocs.org
Other
16 stars 6 forks source link

Space varying material properties #238

Closed dalg24 closed 7 years ago

dalg24 commented 7 years ago

@Rombur I changed the namespace and committed the switch that allows us to overwrite \kappa in the electrode and the separator. All we need is adding a node custom_liquid_electrical_conductivity { expression: ..., variables[optional]: ..., constants[optional]: ... } in material_properties.{electrode,separator}_material.

Rombur commented 7 years ago

tests don't pass

dalg24 commented 7 years ago

ping. in particular, look at c7a4051.

dalg24 commented 7 years ago

only the "timer" test failed so I'd say this is all good

codecov-io commented 7 years ago

Current coverage is 93.41% (diff: 96.98%)

Merging #238 into master will increase coverage by 0.13%

@@             master       #238   diff @@
==========================================
  Files            72         72          
  Lines          4842       4999   +157   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           4517       4670   +153   
- Misses          325        329     +4   
  Partials          0          0
Diff Coverage File Path
•••••••• 84% cpp/source/deal.II/mp_values.templates.h
•••••••• 88% cpp/source/deal.II/post_processor.templates.h
•••••••••• 100% cpp/test/test_mp_values.cc
•••••••••• 100% cpp/source/utils.templates.h
•••••••••• 100% cpp/source/deal.II/equivalent_circuit.cc
•••••••••• 100% ...p/source/deal.II/electrochemical_physics.templates.h
•••••••••• 100% cpp/source/deal.II/mp_values.h
•••••••••• 100% cpp/source/utils.cc
•••••••••• 100% cpp/test/test_parse_params.cc
•••••••••• 100% cpp/source/deal.II/mp_values.cc

Sunburst

Powered by Codecov. Last update 6d1c214...d0eb856