ORNL-CEES / Cap

A library for modeling energy storage devices.
http://cap.readthedocs.org
Other
16 stars 6 forks source link

Add inspector for supercapacitor. #242

Closed Rombur closed 7 years ago

Rombur commented 7 years ago

I have a problem with matplotlib so I can't run any tests... I will use the PR to run the tests, so don't merge this.

dalg24 commented 7 years ago

Somewhere in your test please pass an equivalent circuit to the inspector and make sure in throws the appropriate exception.

codecov-io commented 7 years ago

Current coverage is 93.42% (diff: 95.83%)

Merging #242 into master will increase coverage by <.01%

@@             master       #242   diff @@
==========================================
  Files            72         72          
  Lines          4999       5017    +18   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           4670       4687    +17   
- Misses          329        330     +1   
  Partials          0          0          
Diff Coverage File Path
••••••••• 92% ...on/source/wrappers/energy_storage_device_wrappers.cc
•••••••••• 100% ...thon/source/wrappers/export_energy_storage_device.cc
•••••••••• 100% python/test/test_energy_storage_device_wrappers.py
•••••••••• 100% cpp/source/deal.II/supercapacitor.templates.h

Sunburst

Powered by Codecov. Last update d4bf68d...a2e319f

codecov-io commented 7 years ago

Current coverage is 93.42% (diff: 96.29%)

Merging #242 into master will increase coverage by <.01%

@@             master       #242   diff @@
==========================================
  Files            72         72          
  Lines          4999       5020    +21   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           4670       4690    +20   
- Misses          329        330     +1   
  Partials          0          0          
Diff Coverage File Path
••••••••• 92% ...on/source/wrappers/energy_storage_device_wrappers.cc
•••••••••• 100% cpp/source/deal.II/supercapacitor.templates.h
•••••••••• 100% ...thon/source/wrappers/export_energy_storage_device.cc
•••••••••• 100% python/test/test_energy_storage_device_wrappers.py

Sunburst

Powered by Codecov. Last update d4bf68d...8f60fbf

codecov-io commented 7 years ago

Current coverage is 93.64% (diff: 100%)

Merging #242 into master will increase coverage by 0.22%

@@             master       #242   diff @@
==========================================
  Files            72         72          
  Lines          4999       5051    +52   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           4670       4730    +60   
+ Misses          329        321     -8   
  Partials          0          0          
Diff Coverage File Path
•••••••••• 100% ...thon/source/wrappers/export_energy_storage_device.cc
•••••••••• 100% python/test/test_energy_storage_device_wrappers.py
•••••••••• 100% ...on/source/wrappers/energy_storage_device_wrappers.cc
•••••••••• 100% cpp/source/deal.II/geometry.templates.h
•••••••••• 100% cpp/test/test_geometry.cc
•••••••••• 100% cpp/source/deal.II/supercapacitor.templates.h

Sunburst

Powered by Codecov. Last update cfa1df9...8b9ba78

Rombur commented 7 years ago

OK this is ready for review.

Rombur commented 7 years ago

You should check that the docker compose works for you.

Rombur commented 7 years ago

Ready for re-review.

Rombur commented 7 years ago

Done