Closed Rombur closed 7 years ago
Somewhere in your test please pass an equivalent circuit to the inspector and make sure in throws the appropriate exception.
@@ master #242 diff @@
==========================================
Files 72 72
Lines 4999 5017 +18
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 4670 4687 +17
- Misses 329 330 +1
Partials 0 0
Diff Coverage | File Path |
---|---|
••••••••• 92% | ...on/source/wrappers/energy_storage_device_wrappers.cc |
•••••••••• 100% | ...thon/source/wrappers/export_energy_storage_device.cc |
•••••••••• 100% | python/test/test_energy_storage_device_wrappers.py |
•••••••••• 100% | cpp/source/deal.II/supercapacitor.templates.h |
Powered by Codecov. Last update d4bf68d...a2e319f
@@ master #242 diff @@
==========================================
Files 72 72
Lines 4999 5020 +21
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 4670 4690 +20
- Misses 329 330 +1
Partials 0 0
Diff Coverage | File Path |
---|---|
••••••••• 92% | ...on/source/wrappers/energy_storage_device_wrappers.cc |
•••••••••• 100% | cpp/source/deal.II/supercapacitor.templates.h |
•••••••••• 100% | ...thon/source/wrappers/export_energy_storage_device.cc |
•••••••••• 100% | python/test/test_energy_storage_device_wrappers.py |
Powered by Codecov. Last update d4bf68d...8f60fbf
@@ master #242 diff @@
==========================================
Files 72 72
Lines 4999 5051 +52
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 4670 4730 +60
+ Misses 329 321 -8
Partials 0 0
Diff Coverage | File Path |
---|---|
•••••••••• 100% | ...thon/source/wrappers/export_energy_storage_device.cc |
•••••••••• 100% | python/test/test_energy_storage_device_wrappers.py |
•••••••••• 100% | ...on/source/wrappers/energy_storage_device_wrappers.cc |
•••••••••• 100% | cpp/source/deal.II/geometry.templates.h |
•••••••••• 100% | cpp/test/test_geometry.cc |
•••••••••• 100% | cpp/source/deal.II/supercapacitor.templates.h |
Powered by Codecov. Last update cfa1df9...8b9ba78
OK this is ready for review.
You should check that the docker compose works for you.
Ready for re-review.
Done
I have a problem with matplotlib so I can't run any tests... I will use the PR to run the tests, so don't merge this.