search

ORNL-CEES / Cap

A library for modeling energy storage devices.
http://cap.readthedocs.org
Other
16 stars 6 forks source link

Use matching building type for cap and deal.II #254

Closed Rombur closed 7 years ago

Rombur commented 7 years ago

This works but doesn't fix the bug I have when using the release mode. However, the paths looks correct when using ldd.

codecov-io commented 7 years ago

Codecov Report

Merging #254 into master will increase coverage by 0.92%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #254      +/-   ##
==========================================
+ Coverage   94.06%   94.99%   +0.92%     
==========================================
  Files          67       72       +5     
  Lines        4652     5115     +463     
==========================================
+ Hits         4376     4859     +483     
+ Misses        276      256      -20
Impacted Files Coverage Δ
python/test/test_property_tree_wrappers.py 100% <0%> (ø)
python/test/test_time_evolution.py 100% <0%> (ø)
python/test/test_end_criterion.py 100% <0%> (ø)
python/test/test_stage.py 100% <0%> (ø)
python/test/test_energy_storage_device_wrappers.py 100% <0%> (ø)
python/source/end_criterion.py 100% <0%> (+12.79%) :white_check_mark:
python/source/time_evolution.py 100% <0%> (+25%) :white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5e89d2b...c218de1. Read the comment docs.

dalg24 commented 7 years ago

No more duplicates when deal.II has been built in DebugRelease mode?

Rombur commented 7 years ago

No. This fixes the problem where we would link against against both the release and the debug libraries used by deal.

dalg24 commented 7 years ago

That's what I meant by "duplicate". OK.