search

ORNL-CEES / Cap

A library for modeling energy storage devices.
http://cap.readthedocs.org
Other
16 stars 6 forks source link

Update Dockerfile #256

Closed Rombur closed 7 years ago

Rombur commented 7 years ago

Update boost to 1.63.0, deal.II to 8.5.1, and Trilinos to 12.10.1. Install pandoc from apt instead of pip due to a bug with Jupyterhub (cannot find pandoc installed by pip).

dalg24 commented 7 years ago

Did you build the image? Wanna tag it 17.08.0? Previous image is 10 month old. Should we tag it as well?

Rombur commented 7 years ago

Yes, I have the image. I can tag it and push it. I don't think it is worth going back and retag the old image. Let's just do it starting from now.

codecov-io commented 7 years ago

Codecov Report

Merging #256 into master will not change coverage. The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #256   +/-   ##
=======================================
  Coverage   94.99%   94.99%           
=======================================
  Files          72       72           
  Lines        5115     5115           
=======================================
  Hits         4859     4859           
  Misses        256      256
Impacted Files Coverage Δ
python/source/__init__.py 100% <ø> (ø) :arrow_up:
python/test/test_time_evolution.py 100% <ø> (ø) :arrow_up:
python/test/test_stage.py 100% <ø> (ø) :arrow_up:
python/source/ragone_plot.py 99.25% <ø> (ø) :arrow_up:
python/test/test_property_tree_wrappers.py 100% <ø> (ø) :arrow_up:
python/test/test_impedance_spectroscopy.py 100% <ø> (ø) :arrow_up:
python/test/test_end_criterion.py 100% <ø> (ø) :arrow_up:
python/test/test_ragone_plot.py 100% <ø> (ø) :arrow_up:
python/test/test_observer_pattern.py 100% <ø> (ø) :arrow_up:
python/source/impedance_spectroscopy.py 87.5% <100%> (ø) :arrow_up:
dalg24 commented 7 years ago

You did not push your new image to Docker hub and edit tag in docker/jenkins/docker-compose.yml to make sure the test passes. I remember now I had assembled an image with deal.II in Debug mode. Should we use an ARG for the build type with default value "Release" and build both the release and debug images?

Rombur commented 7 years ago

This is ready to merge. All the images have been updated. Since we talked about it on Friday, I will merge this myself.

Rombur commented 7 years ago

Github seems to have problem right. The tests failed because jenkins couldn't pull the repo...

Rombur commented 7 years ago

Looks like there is a problem with Trilinos. Not sure how the tests passed when I changed the docker-compose.