search

ORNL-CEES / Cap

A library for modeling energy storage devices.
http://cap.readthedocs.org
Other
16 stars 6 forks source link

[WIP] Fix build without dealii (clang-format not applied yet) #262

Closed dalg24 closed 3 years ago

dalg24 commented 7 years ago

fix #261

dalg24 commented 7 years ago

We might need a runtime api call that tells whether Cap was compiled with deal.II or not to emulate the #ifdef WITH_DEAL_II in Python.

masterleinad commented 5 years ago

Any reason not to merge this after formatting?

Rombur commented 5 years ago

I think that would be fine but I don't know if @dalg24 ever tried to compile without deal.II (I assume that's why it's WIP)

dalg24 commented 5 years ago

We need a way to find out whether Cap was built with deal.II or nor from the Python side and then we need to conditionally enable the tests with the supercapacitor. I remember I was looking at how NumPy records whether it was built with BLAS.

masterleinad commented 5 years ago

Isn't that a separate issue besides just being able to compile without deal.II?

dalg24 commented 5 years ago

Isn't that a separate issue besides just being able to compile without deal.II?

Yes and no. It will compile but the tests won't pass.