ORNL-CEES / DataTransferKit

A library for multiphysics solution transfer. ARCHIVED
https://datatransferkit.readthedocs.io/en/dtk-3.0/
BSD 3-Clause "New" or "Revised" License
47 stars 26 forks source link

Remove unneeded Teuchos header #550

Closed aprokop closed 5 years ago

codecov-io commented 5 years ago

Codecov Report

Merging #550 into master will increase coverage by 0.04%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #550      +/-   ##
==========================================
+ Coverage   95.89%   95.93%   +0.04%     
==========================================
  Files         134      134              
  Lines        9594     9591       -3     
==========================================
+ Hits         9200     9201       +1     
+ Misses        394      390       -4
Impacted Files Coverage Δ
...Search/src/details/DTK_DetailsTreeConstruction.hpp 100% <ø> (ø) :arrow_up:
packages/Search/examples/bvh_driver/bvh_driver.cpp 90.9% <ø> (ø) :arrow_up:
packages/Search/test/tstBoostRangeAdapters.cpp 100% <ø> (ø) :arrow_up:
...istributed_tree_driver/distributed_tree_driver.cpp 82.46% <100%> (+1.33%) :arrow_up:
...es/Search/src/details/DTK_DetailsTreeTraversal.hpp 98.11% <0%> (+0.89%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bbfa196...47faabd. Read the comment docs.

dalg24 commented 5 years ago

@aprokop Please look over the changes I added and merge if you are happy with them.

dalg24 commented 5 years ago

Looks good, but there is nothing in this PR to show why you are able to remove boost checks in code and cmake.

Example and tests require Boost. We agreed we would not run them from DTK so I won't bother add the conditional addition of the example in CMake.

aprokop commented 5 years ago

After the discussion we decided that we shouldn't worry about careful handling of Boost right now, as that was already broken once we added boost::program_options to the drivers (which made Boost a required dependency). Search is going to be moved out soon, so the window for "dtk without boost is broken" is going to be short.

dalg24 commented 5 years ago

retest this please