Closed aprokop closed 5 years ago
@aprokop Please look over the changes I added and merge if you are happy with them.
Looks good, but there is nothing in this PR to show why you are able to remove boost checks in code and cmake.
Example and tests require Boost. We agreed we would not run them from DTK so I won't bother add the conditional addition of the example in CMake.
After the discussion we decided that we shouldn't worry about careful handling of Boost right now, as that was already broken once we added boost::program_options
to the drivers (which made Boost a required dependency). Search is going to be moved out soon, so the window for "dtk without boost is broken" is going to be short.
retest this please
Codecov Report
100% <ø> (ø)
90.9% <ø> (ø)
100% <ø> (ø)
82.46% <100%> (+1.33%)
98.11% <0%> (+0.89%)
Continue to review full report at Codecov.