ORNL-CEES / DataTransferKit

A library for multiphysics solution transfer. ARCHIVED
https://datatransferkit.readthedocs.io/en/dtk-3.0/
BSD 3-Clause "New" or "Revised" License
47 stars 26 forks source link

Fix check_format script (spelling) #555

Closed aprokop closed 5 years ago

aprokop commented 5 years ago

The misspelling made it so that the script always returned 0.

aprokop commented 5 years ago

Jenkins failed with ??

[DataTransferKit-GCC54-CUDA90] $ /bin/sh -xe /tmp/jenkins2394460361415622984.sh
+ export BUILD_TYPE=gcc54-cuda90
+ export CUDA_VERSION=9.0
+ cd /var/jenkins/workspace/DataTransferKit-GCC54-CUDA90/docker/jenkins
+ ./docker-run.sh
diff: CUDA_VERSION: No such file or directory
diff: GPU_ARCH: No such file or directory
../nvidia/setup_nvidia_docker_compose.py --extended-file docker-compose.yml --extend-services ci --override-file docker-compose.override.yml
Cannot connect to the nvidia docker plugin. Did you install it? Is the plugin daemon running on this host?
dalg24 commented 5 years ago

Because these environment variables are not defined on the new slave agents

aprokop commented 5 years ago

Because these environment variables are not defined on the new slave agents

So what's the fix here? How does one define those variables on slave agents?

codecov-io commented 5 years ago

Codecov Report

Merging #555 into master will decrease coverage by 0.97%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #555      +/-   ##
==========================================
- Coverage   96.03%   95.06%   -0.98%     
==========================================
  Files         133      110      -23     
  Lines        9543     7110    -2433     
==========================================
- Hits         9165     6759    -2406     
+ Misses        378      351      -27
Impacted Files Coverage Δ
packages/Search/src/details/ArborX_Exception.hpp 0% <0%> (-100%) :arrow_down:
packages/Search/src/details/ArborX_DetailsNode.hpp 66.66% <0%> (-33.34%) :arrow_down:
...Search/src/details/ArborX_DetailsTreeTraversal.hpp 68.51% <0%> (-28.71%) :arrow_down:
...ails/ArborX_DetailsBoundingVolumeHierarchyImpl.hpp 72.57% <0%> (-20.58%) :arrow_down:
...ackages/Search/src/details/ArborX_DetailsUtils.hpp 82.45% <0%> (-17.55%) :arrow_down:
packages/Search/src/details/ArborX_DetailsHeap.hpp 82.5% <0%> (-17.5%) :arrow_down:
...etails/ArborX_DetailsDistributedSearchTreeImpl.hpp 99.55% <0%> (-0.45%) :arrow_down:
...ackages/Search/src/details/ArborX_DetailsStack.hpp 100% <0%> (ø) :arrow_up:
...es/Search/src/details/ArborX_DetailsContainers.hpp 100% <0%> (ø) :arrow_up:
...ges/Search/src/details/ArborX_DetailsKokkosExt.hpp 100% <0%> (ø) :arrow_up:
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8eba410...d267413. Read the comment docs.

aprokop commented 5 years ago

Rebased on master to fix jenkins build.