search

ORNL-CEES / DataTransferKit

A library for multiphysics solution transfer. ARCHIVED
https://datatransferkit.readthedocs.io/en/dtk-3.0/
BSD 3-Clause "New" or "Revised" License
48 stars 26 forks source link

Regenerate Fortran wrappers using the latest SWIG, fixing XL #562

Closed aprokop closed 4 years ago

aprokop commented 5 years ago

I don't understand why master version of the Fortran code does not contain map related functions? It is almost like they were commented out or something during last generation.

However, regenerating puts them in, but fails to build. The problem is that the map functions are defined not in interface, but in MapFactory, and are simply extern in DTK_C_API.h`. The problem with that is that the generated Fortran code has to call them, but ends up with undefined reference.

I cannot simply make it depend on dtk_mapfactory as that already depends on dtk_interface and results in circular dependency.

The quick fix would be to maintain the current behavior, and do not generate the Fortran wrappers for Map functions. We have no current users of that anyway. @sslattery @dalg24 thoughts?

aprokop commented 5 years ago

retest this please

aprokop commented 5 years ago

hmm, can't reproduce the failure in the container.

aprokop commented 5 years ago

It seems that something is off with CUDA. Even the tests that I did not touch do not pass, like tstKokkosView.