Make Trilinos a TPL using Kokkos 3.0

ORNL-CEES / DataTransferKit

A library for multiphysics solution transfer. ARCHIVED

https://datatransferkit.readthedocs.io/en/dtk-3.0/

BSD 3-Clause "New" or "Revised" License

48 stars 26 forks source link

Make Trilinos a TPL using Kokkos 3.0 #566

Closed masterleinad closed 4 years ago

masterleinad commented 4 years ago

Based on top of #451, these are the changes required to build with Trilinos with Kokkos 3.0.

~~We still need to make sure everything works without using deprecated code in Kokkos.~~

masterleinad commented 4 years ago

Is this good enough for the milestone? I can confirm that this works for me locally but since it relies on Kokkos-3.0 it doesn't pass CI at all. I guess it only makes sense to clean this up once we have the release and also Trilinos is updated.

Rombur commented 4 years ago

So what do we need to get this merged? Just update the CI to Kokkos 3.0 and Trilinos master?

masterleinad commented 4 years ago

So what do we need to get this merged? Just update the CI to Kokkos 3.0 and Trilinos master?

Yes, that is what I tested back then. Admittedly, I am not quite sure how to modify CI accordingly.

Rombur commented 4 years ago

Can you post your configure line.

masterleinad commented 4 years ago

Apart from

DataTransferKit_CXX11_FLAGS=-std=c++14

I don't need anything special to compile using a recent ArborX version.

dalg24 commented 4 years ago

Close?

Rombur commented 4 years ago

Yes, the commits are in master