search

ORNL-CEES / DataTransferKit

A library for multiphysics solution transfer. ARCHIVED
https://datatransferkit.readthedocs.io/en/dtk-3.0/
BSD 3-Clause "New" or "Revised" License
47 stars 26 forks source link

Decide on version to use for xSDK release #586

Closed masterleinad closed 3 years ago

masterleinad commented 3 years ago

It seems that both master and 3.1-rc1 are currently failing for xSDK (https://github.com/xsdk-project/xsdk-issues/issues/108#issuecomment-694401442). We should figure out what we want to have in the xSDK release and fix the issues.

aprokop commented 3 years ago

Aren't they failing because of the missing submodule?

masterleinad commented 3 years ago

I haven't checked yet what needs to be done.

aprokop commented 3 years ago

From what i see in spack, submodules are only enabled when cloning master branch. Versions are pulling releases. As releases done using github, they likely don't contains tribits submodule.

masterleinad commented 3 years ago

I think we just need to add the additional dependencies introduced for the SplineInterpolationOperator to the spack package or use a commit before that. I am not quite sure if we should have a tagged commit for that or not.

aprokop commented 3 years ago

Agreed about dependencies, and we probably should tag and make a release, making those dependencies version dependent.

masterleinad commented 3 years ago

I'm building it right now.

masterleinad commented 3 years ago

Anyone opposed to tagging the commit before SplineInterpolationOperator for a release to be used by xSDK? That would likely be easiest.

aprokop commented 3 years ago

Anyone opposed to tagging the commit before SplineInterpolationOperator for a release to be used by xSDK? That would likely be easiest.

I'm ok with that.

masterleinad commented 3 years ago

This should work now but let's wait for the confirmation that this is fine for the release before closing.