ORNL-CEES / DataTransferKit

A library for multiphysics solution transfer. ARCHIVED
https://datatransferkit.readthedocs.io/en/dtk-3.0/
BSD 3-Clause "New" or "Revised" License
47 stars 26 forks source link

Update build system and fix warnings #595

Closed Rombur closed 3 years ago

Rombur commented 3 years ago

I was helping a user when I realized that we do not install our CMake configuration files. We only install DTK version files. This PR fixes that. Since I was changing the build system I updated Tribits. In newer versions of Tribits, we don't need to hack the C++11 flags to use C++14. So I fixed this at the same time. Finally, I fixed a bunch or warnings.

Locally, I have test failing for this PR and for master. Let's see if this PR passes with our CI.

Rombur commented 3 years ago

Jenkins is not working. Probably the same problem that we had with MGMOL and adamantine a while back. I am working on it.

Rombur commented 3 years ago

This is ready to be merged. I had to do one modification since the reviews. I was using a KOKKOS_LAMBDA inside of a constructor which does not work with CUDA. So I created a new function to split the IndexRange pair. I put this function in a new file in Utils. We used to have this kind of functions (like iota) in the Search package but now this has been moved outside DTK that's why I decided to put that function in Utils.