ORNL-CEES / DataTransferKit

A library for multiphysics solution transfer. ARCHIVED
https://datatransferkit.readthedocs.io/en/dtk-3.0/
BSD 3-Clause "New" or "Revised" License
47 stars 26 forks source link

Allow to have ArborX be a TPL #599

Closed Rombur closed 3 years ago

Rombur commented 3 years ago

With this PR, I can use an external ArborX with DTK. You need to set the following configuration variables:

-D DataTransferKit_ENABLE_ArborX_TPL=ON
-D TPL_ArborX_DIR=/path/to/arborx 

The PR is pretty straightforward, the only thing is that when ArborX is a TPL I create a dummy dtk_search library.

Rombur commented 3 years ago

Are all of them necessary?

They are necessary. Tribits is looking for these variables. At first, I had weird bugs where ArborX was a registered TPL at the beginning of the configuration (because one variable was set) but not at the end (because another one was not set).

dalg24 commented 3 years ago

I expect only TPL_ENABLE_<TPL_NAME> and <TRIBITS_PACKAGE>_ENABLE_<TPL_NAME> are required