Closed Rombur closed 2 years ago
Why did you remove MapFactory
and Interface
?
Because there are not used and the tests assume we use CUDA
Are we sure that these are not used by any external users (e.g., ExaAM)?
I thought ExaAm stopped using DTK when they stopped using Truchas
I thought ExaAm stopped using DTK when they stopped using Truchas
Correct in the case of Truchas. But it's now being used in ExaCA. Per John Coleman:
I have integrated DTK into a branch of ExaCA, but it is not in the standard release yet. We were using it
to interpolate thermal data from a finite volume heat transfer model to a cellular-automata grain structure
model for solidification in additive manufacturing.
That's a C++ code using Kokkos. It's probably cleaner if they don't use the C interface.
I'm not sure how it does that, I have not seen the dtk branch.
John is OK with us removing Interface
John is OK with us removing
Interface
And MapFactory
?
Yes MapFactory
too.
With this PR I can pass the test suite on Crusher. The changes made are:
MapFactory
package has been removedInterface
package has been removed (not sure what it means for our link with ForTrilinos)