ORNL-CEES / DataTransferKit

A library for multiphysics solution transfer. ARCHIVED
https://datatransferkit.readthedocs.io/en/dtk-3.0/
BSD 3-Clause "New" or "Revised" License
47 stars 26 forks source link

Add support for Crusher #602

Closed Rombur closed 2 years ago

Rombur commented 2 years ago

With this PR I can pass the test suite on Crusher. The changes made are:

masterleinad commented 2 years ago

Why did you remove MapFactory and Interface?

Rombur commented 2 years ago

Because there are not used and the tests assume we use CUDA

aprokop commented 2 years ago

Are we sure that these are not used by any external users (e.g., ExaAM)?

Rombur commented 2 years ago

I thought ExaAm stopped using DTK when they stopped using Truchas

aprokop commented 2 years ago

I thought ExaAm stopped using DTK when they stopped using Truchas

Correct in the case of Truchas. But it's now being used in ExaCA. Per John Coleman:

I have integrated DTK into a branch of ExaCA, but it is not in the standard release yet. We were using it
to interpolate thermal data from a finite volume heat transfer model to a cellular-automata grain structure
model for solidification in additive manufacturing.
Rombur commented 2 years ago

That's a C++ code using Kokkos. It's probably cleaner if they don't use the C interface.

aprokop commented 2 years ago

I'm not sure how it does that, I have not seen the dtk branch.

Rombur commented 2 years ago

John is OK with us removing Interface

aprokop commented 2 years ago

John is OK with us removing Interface

And MapFactory?

Rombur commented 2 years ago

Yes MapFactory too.