search

ORNL-CEES / DataTransferKit

A library for multiphysics solution transfer. ARCHIVED
https://datatransferkit.readthedocs.io/en/dtk-3.0/
BSD 3-Clause "New" or "Revised" License
47 stars 26 forks source link

Updates for Trilinos 14 #603

Closed masterleinad closed 1 year ago

masterleinad commented 1 year ago

Fixes https://github.com/xsdk-project/xsdk-issues/issues/175.

masterleinad commented 1 year ago

Retest this please.

masterleinad commented 1 year ago

Should we support only the latest Trilinos?

Yes, I think it's sufficient to support the latest releases and I'm pretty sure this pull request is not backward-compatible.

dalg24 commented 1 year ago

Should we support only the latest Trilinos?

Yes, I think it's sufficient to support the latest releases and I'm pretty sure this pull request is not backward-compatible.

Then why guard for the version of Trilinos?

masterleinad commented 1 year ago

Then why guard for the version of Trilinos?

Ah, also from the original pull request. Fixed now.

masterleinad commented 1 year ago

Retest this please.

masterleinad commented 1 year ago

Retest this please.

masterleinad commented 1 year ago

This passes CI now.

masterleinad commented 1 year ago

LGTM. But a question: if we require just the new version of Trilinos, do we actually check that anywhere in CMake? I don't see any

I would just specify it in spack. I don't know if we ever checked the Trilinos version (or ArborX version) at configure time.

masterleinad commented 1 year ago

I would appreciate it if we can get this merged so that we are ready for the xSDK release.