search

ORNL-CEES / thermochimica

Computational library for chemical thermodynamics and phase equilibrium calculation. Multiphysics and standalone estimations of chemical state and constitutive and transport properties.
BSD 3-Clause "New" or "Revised" License
45 stars 25 forks source link

Remove database filename/filepath length limit #107

Closed maxposchmann closed 1 year ago

maxposchmann commented 1 year ago

Reason. Length limits on filepaths are frustrating, hard for users to debug, and don't match anyone's expectation of a modern computer program.

Proposed Solution

  1. Use dynamic string allocation to remove this limit for Fortran and C(++) programs using our APIs.
  2. Use a very long string buffer to practically eliminate this issue for those using our script or graphical interfaces.

Impact Should improve usability for everyone without breaking anything.

maxposchmann commented 1 year ago

@dschwen I've gone ahead and opened an issue for this. It looks like a solution shouldn't be too difficult. Also working on it on the dynamic_filename branch, but currently have some outstanding bugs.

maxposchmann commented 1 year ago

The bugs turned out to be unrelated, but in any case are fixed now.