ORNL-CEES / thermochimica

Computational library for chemical thermodynamics and phase equilibrium calculation. Multiphysics and standalone estimations of chemical state and constitutive and transport properties.
BSD 3-Clause "New" or "Revised" License
43 stars 25 forks source link

Thermochimica GUI reporting incorrect results for NiF2-KF system #57

Closed parikshitbajpai closed 2 years ago

parikshitbajpai commented 2 years ago

Bug Description

As seen in the following image, Thermochimica GUI is reporting an incorrect result for non-solvable systems instead of graceful exit with error message.

image

Information to Reproduce

Impact

This creates confusion and gives a false sense of code working. Can be highly misleading to users who might not be well versed with computational thermochemistry and they might doubt the capability of the code.

maxposchmann commented 2 years ago

This was an issue with the new retry feature, fixed in b1beb5a15af5a1f56bc140920bf307dd967eeb1f