search

ORNL-MDF / mist

Mist is a Python tool for storing, sharing, and using information about materials in models and simulations.
BSD 3-Clause "New" or "Revised" License
2 stars 2 forks source link

Additivefoam input file writer & test #18

Closed hespuck19 closed 2 months ago

hespuck19 commented 4 months ago

Does not account for the fluid flow properties typically found in transportProperties file.

stvdwtt commented 4 months ago

@hespuck19 -- I haven't had a chance to look at the latest commits in detail, but in case you didn't see it yet, the CI failed for your new test. (It looks like the function is expecting a path as input, but isn't getting one or maybe is getting an empty string).

stvdwtt commented 3 months ago

@hespuck19, do you have a preferred order to merge this versus #20 or #21? I see that #21 builds off of this branch.

Options that make sense to me: 1) Finish fixing up this PR and merge it, then merge #20 or #21, then do a new PR to use get_property for the additiveFOAM writer. 2) Fix the test in #20 and merge it, then use get_property in this PR and merge it. 3) Fix the test in #21 and merge it, close this PR without merging (since #21) has the commits, then do a new PR to use get_property for the additiveFOAM writer.

streeve commented 3 months ago

@hespuck19, do you have a preferred order to merge this versus #20 or #21? I see that #21 builds off of this branch.

I opened #22 to clarify that there's an additional failure (that we may want to ignore in order to merge) unrelated to both

Whatever we decide to do, each pull request should address one feature/issue and we can "force" push any branch to get it to a state that we want

stvdwtt commented 3 months ago

Talking to @hespuck19, here's what we want before merging:

streeve commented 2 months ago

@stvdwtt I think I got this mostly working @gknapp1 honestly not sure if this actually works with additivefoam yet