search

ORNL-MDF / mist

Mist is a Python tool for storing, sharing, and using information about materials in models and simulations.
BSD 3-Clause "New" or "Revised" License
2 stars 2 forks source link

Add property helper function #20

Closed streeve closed 1 month ago

streeve commented 2 months ago

Closes #17

streeve commented 2 months ago

@hespuck19 can you take a look at this? Hopefully useful in a number of places

hespuck19 commented 2 months ago

@hespuck19 can you take a look at this? Hopefully useful in a number of places

Definitely looks helpful! I think there may be one section where I don't want to evaluate Laurent polynomials but I think the way its setup now should still work with the changes you suggested there.

streeve commented 2 months ago

Looks like I broke all the tests, do you have time to look more at this, @hespuck19? There's also many more places this function could be used (once it actually works of course)

hespuck19 commented 2 months ago

Looks like I broke all the tests, do you have time to look more at this, @hespuck19? There's also many more places this function could be used (once it actually works of course)

I'll make a new branch and try to implement something that (maybe, hopefully) doesn't break the tests.