search

ORNL-Modelica / Modelica-GNU_ScientificLibrary

GNU General Public License v3.0
10 stars 8 forks source link

Illegal inheritance #1

Closed tbeu closed 7 years ago

tbeu commented 7 years ago

I believe if it is not legal that GNU_ScientificLibrary.Icons extends from GNU_ScientificLibrary.Icons.IconsPackage. See how it is done in the MSL, where the inheritance is missing but the graphics annotation is repeated.

greenwoodms06 commented 7 years ago

I think I understand what your saying but are you getting some sort of warning...? I haven't had any issues with the current implementation...

tbeu commented 7 years ago

Yes, I see this syntax error

Error: attempted redefinition of IconsPackage was ignored
File: C:/Projekte/Modelica-GNU_ScientificLibrary/GNU_ScientificLibrary/Icons/IconsPackage/package.mo, line 2
Using old definition from:
File: C:/Projekte/Modelica-GNU_ScientificLibrary/GNU_ScientificLibrary/Icons/package.mo, line 3
greenwoodms06 commented 7 years ago

Are you using OMEdit, Dymola, jModelica, other...?

I went ahead and opened in OMEdit and noticed the load error of the icons package. I fixed it my last commit... Did that fix the issue you were mentioning?

greenwoodms06 commented 7 years ago

I will close this issue if I have addressed what you were mentioning.