search

ORNL-Modelica / UnrealEngine-FMIPlugin

27 stars 5 forks source link

Lewinj patch 1 #17

Closed lewinj closed 3 years ago

lewinj commented 3 years ago

I redone the endplay function so now the only changes are to A_FMU.cpp and A_FMU.h. I don't know why github thinks I entirely replaced then A_FMU.cpp file, but I have verified that other than the added endplay function they are the same.

greenwoodms06 commented 3 years ago

Have you tried to put the delete mFmu line after the Super... line? If it doesn't matter from your end. move it down there and delete the commented line in EndPlay

greenwoodms06 commented 3 years ago

FYI, if you didn't already know. When you make a pull request, you don't need to make a new one if you need to do more commits. Just make the commits to you branch and they will show up in this pull request.

lewinj commented 3 years ago

I didn't know that, and I'm pretty sure it does matter. I'll make those changes.

greenwoodms06 commented 3 years ago

alright. so for your application everything is good to go on this pull request?

lewinj commented 3 years ago

yes

On Mon, May 3, 2021 at 10:20 AM Scott G @.***> wrote:

alright. so for your application everything is good to go on this pull request?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ORNL-Modelica/UnrealEngine-FMIPlugin/pull/17#issuecomment-831291200, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASXLTOET7RVMR3MJCNY47FDTL2WK7ANCNFSM44A27NZQ .

greenwoodms06 commented 3 years ago

alrighty then. ill accept the merge request and close