search

ORNL-QCI / xacc

XACC - eXtreme-scale Accelerator programming framework
https://xacc.readthedocs.io
BSD 3-Clause "New" or "Revised" License
1 stars 1 forks source link

Tweak build for QIREE (downstream) #4

Closed ausbin closed 4 months ago

ausbin commented 4 months ago

I'm working on linking Qwerty with QIREE, but QIREEConfig.cmake attempts to find_package(XACC 1.0.0), which is not valid unless there is a xacc-config-version.cmake, which this PR adds. Yes we could tweak QIREE's configuration not to do that, but I think this is a valid usecase for software downstream of XACC.

This PR also avoids installing gtest if tests are not being built. If ORNL folks point cmake to $XACC_DIR to find gtest when building QIREE (I have no clue if so), then this is a breaking change. (However, I don't think make install for any software package should install the unit testing framework it uses, in my opinion. Imagine how many different versions of unit testing libraries you'd have in /usr/lib if that were common practice.)

danclaudino commented 4 months ago

Everything looks good. I wholeheartedly agree with not installing gtest by default.