ORNL / AADL

Anderson Acceleration for Deep Learning
12 stars 6 forks source link

requirements.txt added #9

Closed allaffa closed 2 years ago

allaffa commented 2 years ago

This removes the .*txt from the .gitignore, but no file has been added.

Adding the requirements.txt should be done with either a new commit or a new PR.

I'm betting that you're still using git add * which still ignores the extra files and can potentially add temporary files (remember the problem that we had during release).

I had to put in an effort, but I managed to teach myself out of git add *. The only commands that you should be allowed to use are:

# this goes through all the changes line by line and helps you catch last minute problems
git add -p 
# this adds a specific new file
git add <file>

Actually, I am using git add files after the mishap we had some time ago :) The reason why I removed *.txt from .gitignore is because this PR adds requirements.txt, but the file is indeed ignored and untracked unless I remove *.txt from .gitignore

mkstoyanov commented 2 years ago

:) Good point for git add files.

My main comment was that the requirements.txt was missing.