streeve
commented
4 months ago It seems this mainly changes “Cajita” with “Cabana::Grid”. Do we need to run any tests for this?
I don't want to tell you how to review, but I will always say so if I think something needs manual tests/checks. Also the email replies make it difficult to read online, I think because of the firewall
It seems this mainly changes “Cajita” with “Cabana::Grid”. Do we need to run any tests for this?
From: Sam Reeve @.> Date: Wednesday, January 17, 2024 at 12:42 PM To: ORNL/CabanaPD @.> Cc: Seleson, Pablo @.>, Review requested @.> Subject: [EXTERNAL] Re: [ORNL/CabanaPD] Remove deprecated Cajita namespace and target (PR #79)
@streevehttps://urldefense.us/v2/url?u=https-3A__github.com_streeve&d=DwMFaQ&c=v4IIwRuZAmwupIjowmMWUmLasxPEgYsgNI-O7C4ViYc&r=VRaP7JmupExc0vnEchCw2UFh19I9Z2E8U28ZM6bPWFs&m=3YW8M9ka-95BksDLhwcN4vpbo7jvjqc77XL4KHkJRqaT3G0IZEMnp-rGQrG9--iX&s=nUc8ZN6kfS7n1f26Hw-Z_aUvld1lL5yQ6YPg7wL1_20&e= requested your review on: #79https://urldefense.us/v2/url?u=https-3A__github.com_ORNL_CabanaPD_pull_79&d=DwMFaQ&c=v4IIwRuZAmwupIjowmMWUmLasxPEgYsgNI-O7C4ViYc&r=VRaP7JmupExc0vnEchCw2UFh19I9Z2E8U28ZM6bPWFs&m=3YW8M9ka-95BksDLhwcN4vpbo7jvjqc77XL4KHkJRqaT3G0IZEMnp-rGQrG9--iX&s=LoCF6mWntj1p5bqRTiFbes2mL_8-3dg5jo8eIlaFLxE&e= Remove deprecated Cajita namespace and target.
— Reply to this email directly, view it on GitHubhttps://urldefense.us/v2/url?u=https-3A__github.com_ORNL_CabanaPD_pull_79-23event-2D11514496882&d=DwMFaQ&c=v4IIwRuZAmwupIjowmMWUmLasxPEgYsgNI-O7C4ViYc&r=VRaP7JmupExc0vnEchCw2UFh19I9Z2E8U28ZM6bPWFs&m=3YW8M9ka-95BksDLhwcN4vpbo7jvjqc77XL4KHkJRqaT3G0IZEMnp-rGQrG9--iX&s=ykoV--4xsstg2JmXJqkumRj6c9nHJ6X7zZwM8XsBq6g&e=, or unsubscribehttps://urldefense.us/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AHOXN7PXH4O4VCDQIYQIQT3YPAEO7AVCNFSM6AAAAABB66FOBSVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRGUYTINBZGY4DQMQ&d=DwMFaQ&c=v4IIwRuZAmwupIjowmMWUmLasxPEgYsgNI-O7C4ViYc&r=VRaP7JmupExc0vnEchCw2UFh19I9Z2E8U28ZM6bPWFs&m=3YW8M9ka-95BksDLhwcN4vpbo7jvjqc77XL4KHkJRqaT3G0IZEMnp-rGQrG9--iX&s=DuDy1KS5eEXxDPNygR6TDsC0pM4a6DubmuEiXbqbAAQ&e=. You are receiving this because your review was requested.Message ID: @.***>